Page MenuHomePhabricator
Differential D12803

Add PhutilInvalidStateException class
ClosedPublic
Actions

Authored by joshuaspence on May 12 2015, 11:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 5:26 PM
Unknown Object (File)
Thu, Nov 28, 12:31 AM
Unknown Object (File)
Nov 20 2024, 1:38 PM
Unknown Object (File)
Nov 16 2024, 10:24 AM
Unknown Object (File)
Nov 14 2024, 2:17 PM
Unknown Object (File)
Nov 12 2024, 7:48 AM
Unknown Object (File)
Nov 8 2024, 9:56 AM
Unknown Object (File)
Nov 3 2024, 8:18 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUf06c0b71f369: Add PhutilInvalidStateException class
Summary

There's a bunch of Call %s before calling %s! exceptions that can be simplified with a custom script.

Test Plan

Wrote unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5952
Build 5972: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30779.May 12 2015, 11:19 AM
joshuaspence retitled this revision from to Add PhabricatorInvalidStateException.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2015, 11:19 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley edited edge metadata.May 13 2015, 2:56 PM

What do you think about putting this in libphutil? We probably have very few arcanist/libphutil callsites, but this doens't feel Phabricator-specific to me.

joshuaspence added a comment.May 13 2015, 9:04 PM

Yeah, I was considering that. Will do.

joshuaspence updated this revision to Diff 30847.May 13 2015, 9:30 PM
joshuaspence edited edge metadata.

Move to rPHU

joshuaspence updated this revision to Diff 30849.May 13 2015, 9:35 PM

Use PhutilInvalidStateException

joshuaspence retitled this revision from Add PhabricatorInvalidStateException to Add PhutilInvalidStateException class.May 13 2015, 9:36 PM
joshuaspence added a child revision: D12829: Use PhutilInvalidStateException.May 13 2015, 9:37 PM
epriestley accepted this revision.May 13 2015, 9:51 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 13 2015, 9:51 PM
Closed by commit rPHUf06c0b71f369: Add PhutilInvalidStateException class (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 9:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30847

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/exception/PhutilInvalidStateException.php

Loading...
View Options

src/exception/__tests__/PhutilInvalidStateExceptionTestCase.php

Loading...
Phabricator · Built by Phacility