There's a bunch of Call %s before calling %s! exceptions that can be simplified with a custom script.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHUf06c0b71f369: Add PhutilInvalidStateException class
Wrote unit tests.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 5913 Build 5933: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 8,586 ms | PhabricatorCelerityTestCase::testCelerityMaps | |
| 789 ms | CelerityResourceTransformerTestCase::testTransformation | |
| 10,558 ms | DifferentialParseRenderTestCase::testParseRender | |
| 1,790 ms | DiffusionGitFileContentQueryTestCase::testAuthorName | |
| 1,557 ms | PhabricatorAphrontViewTestCase::testHasChildren | |
| View Full Test Results (1 Failed · 16 Passed) |
Event Timeline
Comment Actions
What do you think about putting this in libphutil? We probably have very few arcanist/libphutil callsites, but this doens't feel Phabricator-specific to me.