What do you think about putting this in libphutil? We probably have very few arcanist/libphutil callsites, but this doens't feel Phabricator-specific to me.

Yeah, I was considering that. Will do.

Move to rPHU

Use PhutilInvalidStateException

joshuaspence retitled this revision from Add PhabricatorInvalidStateException to Add PhutilInvalidStateException class.May 13 2015, 9:36 PM

joshuaspence added a child revision: D12829: Use PhutilInvalidStateException.May 13 2015, 9:37 PM

epriestley accepted this revision.May 13 2015, 9:51 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 13 2015, 9:51 PM

Closed by commit rPHUf06c0b71f369: Add PhutilInvalidStateException class (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 9:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

auth/

PhutilOAuthAuthAdapter.php

3 lines

cache/

PhutilDirectoryKeyValueCache.php

11 lines

PhutilMemcacheKeyValueCache.php

5 lines

PhutilOnDiskKeyValueCache.php

11 lines

exception/

PhutilInvalidStateException.php

30 lines

__tests__/

PhutilInvalidStateExceptionTestCase.php

17 lines

parser/

PhutilParserGenerator.php

36 lines

utils/

PhutilEditDistanceMatrix.php

6 lines

Diff 30852

View Options

src/__phutil_library_map__.php

View Options

src/auth/PhutilOAuthAuthAdapter.php

View Options

src/cache/PhutilDirectoryKeyValueCache.php

View Options

src/cache/PhutilMemcacheKeyValueCache.php

View Options

src/cache/PhutilOnDiskKeyValueCache.php

View Options

src/exception/PhutilInvalidStateException.php

View Options

src/exception/tests/PhutilInvalidStateExceptionTestCase.php

View Options

src/parser/PhutilParserGenerator.php

View Options

src/utils/PhutilEditDistanceMatrix.php

Add PhutilInvalidStateException classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30852

src/__phutil_library_map__.php

src/auth/PhutilOAuthAuthAdapter.php

src/cache/PhutilDirectoryKeyValueCache.php

src/cache/PhutilMemcacheKeyValueCache.php

src/cache/PhutilOnDiskKeyValueCache.php

src/exception/PhutilInvalidStateException.php

src/exception/__tests__/PhutilInvalidStateExceptionTestCase.php

src/parser/PhutilParserGenerator.php

src/utils/PhutilEditDistanceMatrix.php

Add PhutilInvalidStateException class
ClosedPublic
Actions

Revision Contents
Changeset List

src/exception/tests/PhutilInvalidStateExceptionTestCase.php