Page MenuHomePhabricator

phtize all the things
ClosedPublic

Authored by joshuaspence on May 11 2015, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 2:59 PM
Unknown Object (File)
Fri, Apr 19, 2:18 AM
Unknown Object (File)
Fri, Apr 19, 2:18 AM
Unknown Object (File)
Fri, Apr 19, 2:18 AM
Unknown Object (File)
Fri, Apr 19, 2:18 AM
Unknown Object (File)
Fri, Apr 19, 2:18 AM
Unknown Object (File)
Fri, Apr 19, 2:18 AM
Unknown Object (File)
Fri, Apr 19, 2:18 AM
Tokens
"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP36e2d02d6ec5: phtize all the things
Summary

phtize a whole bunch of strings in rP.

Test Plan

Intense eyeballing.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/herald/controller/HeraldTranscriptController.php:216XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5899
Build 5919: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to phtize all the things.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Think I got a couple of actual issues, and then some possible tweaks. Tweaks are mostly about giving translators slightly more flexibility, even though it means they might make a few more mistakes. I don't really care too much about these, they're rare, and we can always adjust them when we start really translating.

  • Large blocks: I think it's OK to trust translators to handle large blocks of text. They may want to add more/fewer paragraphs or reformat text to flow better in a different language.
  • Glyphs: I think it's OK to let translators translate "X", "...", etc., glyphs, since there might be a different glyph which makes more sense in their language.
  • State exceptions: I think you fixed these elsewhere already.
scripts/user/account_admin.php
15–26

This kind of change is possibly not desirable.

Generally, translators should be free to express large blocks of text using more or fewer paragraphs than the input text uses.

The primary goal of separating trailing "\n" is to make errors with trailing whitespace impossible for translators, not to prevent them from changing the number of paragraphs a translation uses or prevent them from translating newlines.

src/applications/audit/constants/PhabricatorAuditActionConstants.php
18–19

It isn't necessarily bad to let translators change these glyphs.

src/applications/audit/editor/PhabricatorAuditEditor.php
614

I believe this isn't human-readable in any client, and probably should not be translated. Translating it likely means that a user changing their translation unnecessarily breaks mail threading in some clients.

src/applications/auth/controller/PhabricatorAuthLoginController.php
73

Unusual string concatenation?

src/applications/auth/controller/PhabricatorEmailLoginController.php
88

These next two are maybe-better as big pht()s.

src/applications/auth/provider/PhabricatorAuthProvider.php
18

State exception?

src/applications/config/check/PhabricatorAuthSetupCheck.php
30

Old approach was untranslatable, but new approach doesn't have any link text!

src/applications/config/option/PhabricatorAuthenticationConfigOptions.php
36

The {{x}} syntax linked these, so we've lost links here. This is probably a net loss, even though these blocks are harder to mistakenly mis-translate now.

src/applications/config/option/PhabricatorConfigOption.php
127

State exception?

src/applications/config/schema/PhabricatorConfigSchemaQuery.php
14

state exception

src/applications/differential/constants/DifferentialAction.php
125–127

3X reasonably translatable glyphs

src/applications/differential/parser/DifferentialHunkParser.php
39

state exception x 4

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
503

2X glyph translation reasonable

src/applications/diffusion/controller/DiffusionCommitTagsController.php
54

Reasonably translatable glyph.

src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php
20

state exception

src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php
15

state exception

src/applications/diffusion/query/lowlevel/DiffusionLowLevelQuery.php
20

state exception

src/applications/diviner/atom/DivinerAtom.php
98

2X State exception

src/applications/doorkeeper/view/DoorkeeperTagView.php
15

state exception

src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php
511–517

Reasonably translatable glyphs.

src/applications/feed/story/PhabricatorFeedStoryPhriction.php
89

oh boy hahaha

src/applications/files/controller/PhabricatorFileDataController.php
230

state exception

src/applications/files/controller/PhabricatorFileDeleteController.php
41

Not really related, but could appendparagraph().

src/applications/herald/storage/HeraldRule.php
135

Arguably a StateException

src/applications/legalpad/controller/LegalpadDocumentSignController.php
656

Probably better as a large block.

src/applications/maniphest/view/ManiphestTaskResultListView.php
236

Glyph

src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
60–64

Probably better to just let translators do their best?

src/applications/oauthserver/PhabricatorOAuthServer.php
37

2x state exception

src/applications/paste/view/PasteEmbedView.php
30

state exception

src/applications/people/storage/PhabricatorUser.php
551

Probably better as a big block.

src/applications/pholio/view/PholioMockEmbedView.php
20

state exception

src/applications/phortune/cart/PhortuneSubscriptionCart.php
37

state

src/applications/phortune/control/PhortuneMonthYearExpiryControl.php
41

state

src/applications/policy/filter/PhabricatorPolicyFilter.php
115

state 2x

src/applications/repository/engine/PhabricatorRepositoryEngine.php
26

state

src/applications/repository/storage/PhabricatorRepository.php
1621

"Almaanc" still misspelled

src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php
229–231

Glyphs

src/applications/slowvote/view/SlowvoteEmbedView.php
25

state

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditor.php
58

state

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
977

state

This revision is now accepted and ready to land.May 14 2015, 2:26 PM

Oh, can you hold off on landing this until Monday, though? The Phacility cluster deploys happen approximately on Saturday mornings, and I'd like more than 24 hours between this landing and doing a deploy.

joshuaspence marked 38 inline comments as done.

As requested

Rebase. I will probably land this in a few days, after I eyeball it again.

This revision was automatically updated to reflect the committed changes.