Page MenuHomePhabricator

Give users an explicit error if they try to upload a too-large diff to Differential
ClosedPublic

Authored by epriestley on Jan 9 2016, 2:49 AM.
Tags
None
Referenced Files
F14393528: D14977.diff
Sat, Dec 21, 11:40 PM
F14380335: D14977.id36184.diff
Sat, Dec 21, 3:45 AM
Unknown Object (File)
Sat, Dec 14, 5:03 AM
Unknown Object (File)
Thu, Dec 12, 6:20 PM
Unknown Object (File)
Wed, Dec 11, 8:23 PM
Unknown Object (File)
Nov 12 2024, 7:14 AM
Unknown Object (File)
Nov 3 2024, 6:35 AM
Unknown Object (File)
Oct 23 2024, 2:29 PM
Subscribers
None

Details

Summary

Ref T8612. If a change affects more than 10K paths + hunks, tell the user it's too big and don't bother trying to write it. We're mostly bounded by INSERTs here.

Also, fix an issue with file upload errors. The keys are real PHP constants, but were accidentally converted to strings in D12797, causing every error to show as "unknown error".

Test Plan

Screen Shot 2016-01-08 at 6.44.07 PM.png (1×2 px, 237 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give users an explicit error if they try to upload a too-large diff to Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.

This is only on the web UI pathway, you can still try to perform these submissions via arc.

joshuaspence edited edge metadata.
joshuaspence added inline comments.
src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php
61

"Differential User Guide: Large Changes" might not be translatable.

This revision is now accepted and ready to land.Jan 9 2016, 2:52 AM
This revision was automatically updated to reflect the committed changes.