Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings

Commits

rPHUe8588c7ef041: Fix text lint issues

Summary

Ref T5105. This is a proof-of-concept for D11458.

Test Plan

arc lint --everything

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4426
Build 4440: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28018.Feb 3 2015, 10:26 AM

joshuaspence retitled this revision from to Fix text lint issues.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D11458: Modify `ArcanistTextLinter` to respect `.editorconfig`.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 3 2015, 10:26 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Minor changes

epriestley accepted this revision.Feb 3 2015, 7:48 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2015, 7:48 PM

joshuaspence updated this object.Feb 10 2015, 8:47 AM

joshuaspence edited edge metadata.

joshuaspence added a task: T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.

Further work

Change charset

Remove some unneeded changes

Minor changes

Reordering

epriestley added inline comments.Feb 10 2015, 2:19 PM

.arclint
1	(You're presumably on top of it, but this has test-only changes, so make sure those get reverted before committing.)

Closed by commit rPHUe8588c7ef041: Fix text lint issues (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 11 2015, 10:58 AM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D11741: Add trailing whitespace.Feb 11 2015, 11:09 AM

joshuaspence mentioned this in rPHUf47f8d27fc30: Add trailing whitespace.Feb 11 2015, 7:59 PM

Fix text lint issues
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28255

.arclint

.editorconfig

LICENSE

src/console/tests/wrap/long.txt

src/console/tests/wrap/long.txt.expect

src/console/tests/wrap/plain.txt

src/console/tests/wrap/plain.txt.expect

src/console/tests/wrap/trailing-space-prompt.txt

src/console/tests/wrap/trailing-space-prompt.txt.expect

src/console/tests/wrap/utf8.txt

src/console/tests/wrap/utf8.txt.expect

Fix text lint issuesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28255

.arclint

.editorconfig

LICENSE

src/console/__tests__/wrap/long.txt

src/console/__tests__/wrap/long.txt.expect

src/console/__tests__/wrap/plain.txt

src/console/__tests__/wrap/plain.txt.expect

src/console/__tests__/wrap/trailing-space-prompt.txt

src/console/__tests__/wrap/trailing-space-prompt.txt.expect

src/console/__tests__/wrap/utf8.txt

src/console/__tests__/wrap/utf8.txt.expect

Fix text lint issues
ClosedPublic
Actions

Revision Contents
Changeset List

src/console/tests/wrap/long.txt

src/console/tests/wrap/long.txt.expect

src/console/tests/wrap/plain.txt

src/console/tests/wrap/plain.txt.expect

src/console/tests/wrap/trailing-space-prompt.txt

src/console/tests/wrap/trailing-space-prompt.txt.expect

src/console/tests/wrap/utf8.txt

src/console/tests/wrap/utf8.txt.expect