Page MenuHomePhabricator
Differential D11641

Fix text lint issues
ClosedPublic
Actions

Authored by joshuaspence on Feb 3 2015, 10:26 AM.
Tags
None
Referenced Files
F14407237: D11641.id28257.diff
Tue, Dec 24, 2:30 AM
Unknown Object (File)
Fri, Dec 20, 5:48 PM
Unknown Object (File)
Fri, Dec 20, 4:55 AM
Unknown Object (File)
Tue, Dec 17, 10:28 AM
Unknown Object (File)
Tue, Dec 17, 7:00 AM
Unknown Object (File)
Tue, Dec 17, 6:03 AM
Unknown Object (File)
Tue, Dec 17, 3:24 AM
Unknown Object (File)
Sun, Dec 15, 3:57 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings
Commits
rPHUe8588c7ef041: Fix text lint issues
Summary

Ref T5105. This is a proof-of-concept for D11458.

Test Plan

arc lint --everything

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4274
Build 4287: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28018.Feb 3 2015, 10:26 AM
joshuaspence retitled this revision from to Fix text lint issues.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D11458: Modify `ArcanistTextLinter` to respect `.editorconfig`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 3 2015, 10:26 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 28019.Feb 3 2015, 10:35 AM
joshuaspence edited edge metadata.

Minor changes

epriestley accepted this revision.Feb 3 2015, 7:48 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 7:48 PM
joshuaspence updated this object.Feb 10 2015, 8:47 AM
joshuaspence edited edge metadata.
joshuaspence added a task: T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.
joshuaspence updated this revision to Diff 28253.Feb 10 2015, 8:55 AM

Further work

joshuaspence updated this revision to Diff 28254.Feb 10 2015, 8:57 AM

Change charset

joshuaspence updated this revision to Diff 28255.Feb 10 2015, 9:10 AM

Remove some unneeded changes

joshuaspence updated this revision to Diff 28256.Feb 10 2015, 9:41 AM

Minor changes

joshuaspence updated this revision to Diff 28257.Feb 10 2015, 9:47 AM

Reordering

epriestley added inline comments.Feb 10 2015, 2:19 PM
.arclint
1 ↗(On Diff #28257)

(You're presumably on top of it, but this has test-only changes, so make sure those get reverted before committing.)

Closed by commit rPHUe8588c7ef041: Fix text lint issues (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 11 2015, 10:58 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D11741: Add trailing whitespace.Feb 11 2015, 11:09 AM
joshuaspence mentioned this in rPHUf47f8d27fc30: Add trailing whitespace.Feb 11 2015, 7:59 PM

Revision Contents
Changeset List

PathSize
13 lines
1 line

Diff 28018

View Options

.editorconfig

Loading...
View Options

LICENSE

Loading...
Phabricator · Built by Phacility