Page MenuHomePhabricator
Differential D11504

Add a linter rule for PHP indentation
AbandonedPublic
Actions

Authored by joshuaspence on Jan 26 2015, 10:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 8:09 AM
Unknown Object (File)
Thu, Jan 30, 12:12 PM
Unknown Object (File)
Wed, Jan 22, 10:39 PM
Unknown Object (File)
Wed, Jan 22, 2:04 PM
Unknown Object (File)
Tue, Jan 21, 10:07 AM
Unknown Object (File)
Fri, Jan 17, 12:48 AM
Unknown Object (File)
Mon, Jan 13, 3:38 AM
Unknown Object (File)
Thu, Jan 9, 2:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

WIP. Depends on D12295.

Test Plan

WIP

Diff Detail

Repository
rARC Arcanist
Branch
xhp-indent
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:55XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:56XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:58XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:59XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:210XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3115XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3118XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3121XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3124XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3126XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3129XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3142XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3144XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3147XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3163XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3166XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3171XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3175XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3177XHP54Indentation
Advicesrc/lint/linter/ArcanistXHPASTLinter.php:3180XHP54Indentation
Unit
Test Failures
Build Status
Buildable 4053
Build 4066: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

TimeTest
220 msArcanistXHPASTLinterTestCase::testLinter
673 msArcanistCSSLintLinterTestCase::testLinter
116 msArcanistCSSLintLinterTestCase::testVersion
229 msArcanistChmodLinterTestCase::testLinter
241 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 38 Passed · 12 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 27664.Jan 26 2015, 10:12 AM
joshuaspence retitled this revision from to Add a linter rule for PHP indentation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 26 2015, 10:12 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence mentioned this in D10440: Add an XHPAST linter rule to ensure that only one statement exists per line.Jan 26 2015, 10:13 AM
epriestley requested changes to this revision.Jan 26 2015, 3:14 PM
epriestley added a reviewer: epriestley.

Just pushing this out of my queue for now, I'm excited about it if you can make it work.

I'm wildly amused by this diff getting flagged by itself.

This revision now requires changes to proceed.Jan 26 2015, 3:14 PM
joshuaspence updated this revision to Diff 27758.Jan 28 2015, 11:15 AM
joshuaspence edited edge metadata.

Somewhat working

Herald added a subscriber: Korvin. · View Herald TranscriptJan 28 2015, 11:15 AM
joshuaspence updated this revision to Diff 27759.Jan 28 2015, 11:48 AM
joshuaspence edited edge metadata.

Somewhat working

joshuaspence updated this revision to Diff 28041.Feb 3 2015, 7:50 PM

Further work, still WIP

joshuaspence mentioned this in D12295: Add a method to get the indentation for an XHPASTNode.Apr 5 2015, 12:15 PM
joshuaspence mentioned this in rPHUd30d314dc8eb: Add a method to get the indentation for an XHPASTNode.Apr 6 2015, 9:44 PM
joshuaspence updated this revision to Diff 30205.Apr 27 2015, 9:29 PM

Rebase, still not working

joshuaspence updated this object.Jun 1 2015, 9:08 PM
joshuaspence added a parent revision: D12295: Add a method to get the indentation for an XHPASTNode.
joshuaspence updated this revision to Diff 31635.Jun 1 2015, 9:38 PM

Further work, seems to work reasonably well but still needs work

joshuaspence abandoned this revision.May 17 2019, 1:09 AM

Not actively working on this.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
80 lines

Diff 27664

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility