HomePhabricator

Add a linter rule to detect call-time pass-by-reference

Authored by joshuaspence.

Description

Add a linter rule to detect call-time pass-by-reference

Summary: Call-time pass-by-reference is an awful "feature" of PHP that is deprecated and removed in PHP 5.4 (see http://us1.php.net/manual/en/migration54.incompatible.php). Add a linter rule to ArcanistXHPASTLinter to detect the use of this feature and raise an error.

Test Plan: Added a test case for arc unit.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10537

Details

Committed
joshuaspenceJan 22 2015, 8:56 PM
Pushed
joshuaspenceJan 22 2015, 9:02 PM
Reviewer
Blessed Reviewers
Differential Revision
D10537: Add a linter rule to detect call-time pass-by-reference
Parents
rARC0b22838ccaa8: Allow `arc unit --everything` to work without a base commit
Branches
Unknown
Tags
Unknown