Page MenuHomePhabricator
Differential D12296

Improve array comma rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 9:47 AM
Unknown Object (File)
Fri, Dec 20, 9:46 AM
Unknown Object (File)
Wed, Dec 4, 6:20 PM
Unknown Object (File)
Thu, Nov 28, 10:55 AM
Unknown Object (File)
Tue, Nov 26, 8:53 PM
Unknown Object (File)
Tue, Nov 26, 1:58 PM
Unknown Object (File)
Mon, Nov 25, 7:39 AM
Unknown Object (File)
Sun, Nov 24, 1:56 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC3a5ffdc2fdf2: Improve array comma rule
Summary

Improve ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR in handling multi-line arrays, see D12280 and D12281 for example. Depends on D12295.

Test Plan

Updated unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29499.Apr 5 2015, 12:05 PM
joshuaspence retitled this revision from to Improve array comma rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D12295: Add a method to get the indentation for an XHPASTNode.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 12:05 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence mentioned this in D12281: Fix some odd looking arrays.Apr 5 2015, 12:27 PM
joshuaspence mentioned this in D12280: Fix an odd looking array.
joshuaspence mentioned this in rARC3eacb08273de: Fix an odd looking array.Apr 5 2015, 12:29 PM
joshuaspence mentioned this in rPea376685ae9e: Fix some odd looking arrays.
joshuaspence mentioned this in D12295: Add a method to get the indentation for an XHPASTNode.Apr 5 2015, 1:01 PM
joshuaspence updated this object.Apr 5 2015, 1:05 PM
joshuaspence edited edge metadata.
joshuaspence updated this object.

I also want to modify this to be able to perform the following fix:

array(
  1,
  2,
-  3,);
+  3,
+);
epriestley accepted this revision.Apr 6 2015, 1:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:24 PM
joshuaspence mentioned this in rPHUd30d314dc8eb: Add a method to get the indentation for an XHPASTNode.Apr 6 2015, 9:44 PM
Closed by commit rARC3a5ffdc2fdf2: Improve array comma rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 6 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
18 lines
__tests__/
xhpast/
24 lines

Diff 29564

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/array-comma.lint-test

Loading...
Phabricator · Built by Phacility