Page MenuHomePhabricator

Create a custom exception class for missing linter dependencies
ClosedPublic

Authored by joshuaspence on Jan 4 2015, 10:35 AM.
Tags
None
Referenced Files
F19797160: D11205.id.diff
Fri, Feb 27, 6:44 PM
F19694546: D11205.id.diff
Tue, Feb 10, 10:30 AM
F19543132: D11205.id26878.diff
Jan 22 2026, 3:16 PM
F19436111: D11205.id26878.diff
Dec 28 2025, 3:16 PM
F19436108: D11205.id27000.diff
Dec 28 2025, 3:15 PM
F19435915: D11205.id.diff
Dec 28 2025, 3:07 PM
F19434971: D11205.diff
Dec 28 2025, 2:46 PM
F18871849: D11205.id26878.diff
Nov 5 2025, 12:52 AM

Details

Summary

I feel that we are abusing ArcanistUsageException. Throw a more tailed exception instead. Depends on D11197.

Test Plan

arc lint, I guess.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3557
Build 3565: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Create a custom exception class for missing linter dependencies.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Agreed that these cases feel overbroad for UsageException.

This revision is now accepted and ready to land.Jan 4 2015, 4:40 PM

Thoughts on not extending from ArcanistUsageException?

Oh, yeah, I probably wouldn't extend.

Any exception could technically be considered the result of someone misusing something, but I think that distinction becomes meaningless long before we get into a major configuration issue like missing software dependencies.

This revision was automatically updated to reflect the committed changes.