Page MenuHomePhabricator

Create a custom exception class for missing linter dependencies
ClosedPublic

Authored by joshuaspence on Jan 4 2015, 10:35 AM.
Tags
None
Referenced Files
F15541562: D11205.id27000.diff
Fri, Apr 25, 12:15 PM
F15541561: D11205.id26878.diff
Fri, Apr 25, 12:15 PM
F15529745: D11205.diff
Tue, Apr 22, 10:12 PM
F15527484: D11205.id26878.diff
Tue, Apr 22, 4:01 AM
F15518311: D11205.diff
Sat, Apr 19, 12:36 PM
F15472313: D11205.id26878.diff
Sat, Apr 5, 12:38 PM
F15462507: D11205.id26878.diff
Tue, Apr 1, 3:31 PM
F15454894: D11205.id27000.diff
Sat, Mar 29, 9:07 PM

Details

Summary

I feel that we are abusing ArcanistUsageException. Throw a more tailed exception instead. Depends on D11197.

Test Plan

arc lint, I guess.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3557
Build 3565: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Create a custom exception class for missing linter dependencies.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Agreed that these cases feel overbroad for UsageException.

This revision is now accepted and ready to land.Jan 4 2015, 4:40 PM

Thoughts on not extending from ArcanistUsageException?

Oh, yeah, I probably wouldn't extend.

Any exception could technically be considered the result of someone misusing something, but I think that distinction becomes meaningless long before we get into a major configuration issue like missing software dependencies.

This revision was automatically updated to reflect the committed changes.