Page MenuHomePhabricator

Create a custom exception class for missing linter dependencies
ClosedPublic

Authored by joshuaspence on Jan 4 2015, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 12:48 AM
Unknown Object (File)
Sat, Feb 8, 12:48 AM
Unknown Object (File)
Sat, Feb 8, 12:48 AM
Unknown Object (File)
Sat, Feb 8, 12:48 AM
Unknown Object (File)
Tue, Feb 4, 1:45 AM
Unknown Object (File)
Tue, Feb 4, 1:45 AM
Unknown Object (File)
Wed, Jan 29, 3:36 PM
Unknown Object (File)
Tue, Jan 28, 4:41 AM

Details

Summary

I feel that we are abusing ArcanistUsageException. Throw a more tailed exception instead. Depends on D11197.

Test Plan

arc lint, I guess.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Create a custom exception class for missing linter dependencies.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Agreed that these cases feel overbroad for UsageException.

This revision is now accepted and ready to land.Jan 4 2015, 4:40 PM

Thoughts on not extending from ArcanistUsageException?

Oh, yeah, I probably wouldn't extend.

Any exception could technically be considered the result of someone misusing something, but I think that distinction becomes meaningless long before we get into a major configuration issue like missing software dependencies.

This revision was automatically updated to reflect the committed changes.