Page MenuHomePhabricator

Create a custom exception class for missing linter dependencies
ClosedPublic

Authored by joshuaspence on Jan 4 2015, 10:35 AM.
Tags
None
Referenced Files
F18871849: D11205.id26878.diff
Wed, Nov 5, 12:52 AM
F18867824: D11205.diff
Tue, Nov 4, 2:52 AM
F18810014: D11205.id27000.diff
Oct 19 2025, 6:52 PM
F18808827: D11205.id26878.diff
Oct 19 2025, 8:57 AM
F18785149: D11205.id.diff
Oct 13 2025, 8:38 PM
F18758143: D11205.id.diff
Oct 5 2025, 8:53 PM
F18745752: D11205.diff
Oct 3 2025, 9:10 AM
F18712348: D11205.id.diff
Sep 29 2025, 5:22 AM

Details

Summary

I feel that we are abusing ArcanistUsageException. Throw a more tailed exception instead. Depends on D11197.

Test Plan

arc lint, I guess.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Create a custom exception class for missing linter dependencies.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Agreed that these cases feel overbroad for UsageException.

This revision is now accepted and ready to land.Jan 4 2015, 4:40 PM

Thoughts on not extending from ArcanistUsageException?

Oh, yeah, I probably wouldn't extend.

Any exception could technically be considered the result of someone misusing something, but I think that distinction becomes meaningless long before we get into a major configuration issue like missing software dependencies.

This revision was automatically updated to reflect the committed changes.