Page MenuHomePhabricator
Differential D11205

Create a custom exception class for missing linter dependencies
ClosedPublic
Actions

Authored by joshuaspence on Jan 4 2015, 10:35 AM.
Tags
None
Referenced Files
F13193539: D11205.diff
Sun, May 12, 2:39 PM
F13185147: D11205.diff
Sat, May 11, 2:38 AM
Unknown Object (File)
Tue, May 7, 4:58 AM
Unknown Object (File)
Fri, May 3, 2:22 AM
Unknown Object (File)
Mon, Apr 29, 1:48 PM
Unknown Object (File)
Wed, Apr 24, 10:14 PM
Unknown Object (File)
Sun, Apr 21, 3:50 PM
Unknown Object (File)
Wed, Apr 17, 2:01 PM
View All Files
Subscribers
avivey
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC6eed5c251411: Create a custom exception class for missing linter dependencies
Summary

I feel that we are abusing ArcanistUsageException. Throw a more tailed exception instead. Depends on D11197.

Test Plan

arc lint, I guess.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26878.Jan 4 2015, 10:35 AM
joshuaspence retitled this revision from to Create a custom exception class for missing linter dependencies.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D11197: Create an `ArcanistExternalLinterTestCase` class.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 4 2015, 10:35 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 4 2015, 4:40 PM
epriestley mentioned this in D10773: Fix linter config check.
epriestley edited edge metadata.

Agreed that these cases feel overbroad for UsageException.

This revision is now accepted and ready to land.Jan 4 2015, 4:40 PM
avivey added a subscriber: avivey.Jan 4 2015, 7:21 PM
joshuaspence added a comment.Jan 4 2015, 8:43 PM

Thoughts on not extending from ArcanistUsageException?

epriestley added a comment.Jan 4 2015, 9:21 PM

Oh, yeah, I probably wouldn't extend.

Any exception could technically be considered the result of someone misusing something, but I think that distinction becomes meaningless long before we get into a major configuration issue like missing software dependencies.

Closed by commit rARC6eed5c251411: Create a custom exception class for missing linter dependencies (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 11:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27000

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistExternalLinter.php

Loading...
View Options

src/lint/linter/ArcanistJSHintLinter.php

Loading...
View Options

src/lint/linter/ArcanistMissingLinterException.php

Loading...
View Options

src/lint/linter/ArcanistPyLintLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
Phabricator · Built by Phacility