Page MenuHomePhabricator

Allow arc patch to keep empty commits
AbandonedPublic

Authored by vm on Sep 8 2014, 6:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 7 2026, 8:32 AM
Unknown Object (File)
Mar 31 2026, 10:06 PM
Unknown Object (File)
Mar 17 2026, 9:42 PM
Unknown Object (File)
Mar 7 2026, 9:12 PM
Unknown Object (File)
Mar 4 2026, 7:59 AM
Unknown Object (File)
Feb 7 2026, 2:32 AM
Unknown Object (File)
Jan 19 2026, 5:45 PM
Unknown Object (File)
Jan 18 2026, 5:47 PM

Details

Summary

This is in an effort to simplify test automation around dependent diffs workflow.
If you have dependent diffs where some of the dependencies have already landed into HEAD, a arc patch --nobranch on the dependent diff fails since 'get cherry-pick' does not allow empty commits.
This lets you set a flag that gets passed down to git cherry-pick which allows and keeps empty commits around.

Fixes one of the problems mentioned in T5986

Test Plan

arc patch --nobranch D1 fails, but arc patch --nobranch --keep-redundant-commits D1 runs successfully and adds a empty commit to the working copy.

Diff Detail

Repository
rARC Arcanist
Branch
kec
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2464
Build 2468: [Placeholder Plan] Wait for 30 Seconds