HomePhabricator

Pass conduit credentials down to children workflow

Description

Pass conduit credentials down to children workflow

Summary:
Calling arc patch on a diff that's dependent on a different diff tries to patch the parent first.
To patch the parent a child workflow is created, and a conduit is passed down, but the credentials are not and it is not marked as authenticated.

Then when the child tries to get the commit message for the dependency, it checks isConduitAuthenticated() https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistPatchWorkflow.php;2c3268f03ed70d3221eb1642bIc99ebb39b12902e$800 and on failure pops up an interactive editor for the commit message.

Instead we just pass down the credentials to the childred and mark them as authenticated, so this is not a problem.

Test Plan: With two diffs where DA2 depends on DA1, run arc patch --force --nobranch DA2 ... this no longer pops an interactive editor for the commit message for the dependency.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: hach-que, seshness, epriestley, Korvin

Maniphest Tasks: T5986

Differential Revision: https://secure.phabricator.com/D10381

Details

Provenance
vmAuthored on
epriestleyCommitted on Sep 8 2014, 2:42 PM
epriestleyPushed on Sep 8 2014, 2:42 PM
Reviewer
Blessed Reviewers
Differential Revision
D10381: Pass conduit credentials down to children workflow
Parents
rARCc8f15136c8c0: phutil_utf8_shorten => PhutilUTF8StringTruncator
Branches
Unknown
Tags
Unknown

Event Timeline