This is still a WIP. I would also like to add autofixing to this (although this may be difficult) and also add some whitelisted constructs, such as for loops. Just seeking some initial feedback.
Details
Details
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- xhpast-oneperline
- Lint
Lint Passed Severity Location Code Message Advice src/lint/linter/ArcanistXHPASTLinter.php:49 XHP47 One Statement Per Line Advice src/lint/linter/ArcanistXHPASTLinter.php:2523 XHP47 One Statement Per Line Advice src/lint/linter/ArcanistXHPASTLinter.php:2534 XHP47 One Statement Per Line Advice src/lint/linter/ArcanistXHPASTLinter.php:2534 XHP47 One Statement Per Line Advice src/lint/linter/ArcanistXHPASTLinter.php:2534 XHP47 One Statement Per Line Advice src/lint/linter/ArcanistXHPASTLinter.php:2537 XHP47 One Statement Per Line Advice src/lint/linter/ArcanistXHPASTLinter.php:2541 XHP47 One Statement Per Line Advice src/lint/linter/ArcanistXHPASTLinter.php:2549 XHP47 One Statement Per Line - Unit
Test Failures - Build Status
Buildable 2460 Build 2464: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 0 ms | testXHPASTLint | |
| 0 ms | testCSSLintLinter | |
| 0 ms | testClosureLinter | |
| 0 ms | testCoffeeLintLinter | |
| 0 ms | testFixLetterCase | |
| View Full Test Results (1 Failed · 21 Passed · 5 Skipped) |
Event Timeline
Comment Actions
Hmm, I wonder if looking for n_STATEMENT or whatever might be cleaner? Not sure if that would get you everything you want, though.