HomePhabricator

Fix two linter issues

Description

Fix two linter issues

Summary:

  • The "exclude static variable access" branch in XHPAST incorrectly excluded all variables in a function or method which used any static access (we were selecting the wrong root node for exclusion).
  • The "PHPLinter" regexp did not work with 5.4.30. Make it more permissive in what it parses.

Test Plan:

  • Added a failing unit test for the variable case and made it pass.
  • PHPLinter tests now pass under 5.4.30

Reviewers: joshuaspence, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11087

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Dec 30 2014, 6:02 PM
Reviewer
btrahan
Differential Revision
D11087: Fix two linter issues
Parents
rARC721bdf424bf3: Use `new FutureIterator` instead of `Futures`
Branches
Unknown
Tags
Unknown