Paths

Table of Contentst

Differential D10440

Add an XHPAST linter rule to ensure that only one statement exists per line
AbandonedPublic
Actions

Authored by joshuaspence on Sep 8 2014, 3:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 1, 2:36 AM

	Unknown Object (File)
	Sat, Dec 28, 2:23 PM

	Unknown Object (File)
	Tue, Dec 24, 4:01 AM

	Unknown Object (File)
	Dec 17 2024, 6:34 AM

	Unknown Object (File)
	Dec 12 2024, 6:59 AM

	Unknown Object (File)
	Dec 9 2024, 3:04 PM

	Unknown Object (File)
	Dec 7 2024, 7:10 PM

	Unknown Object (File)
	Dec 6 2024, 12:33 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

This is still a WIP. I would also like to add autofixing to this (although this may be difficult) and also add some whitelisted constructs, such as for loops. Just seeking some initial feedback.

Test Plan

WIP

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 3407
Build 3414: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	testXHPASTLint
	0 ms	testCSSLintLinter
	0 ms	testClosureLinter
	0 ms	testCoffeeLintLinter
	0 ms	testFixLetterCase
		View Full Test Results (1 Failed · 21 Passed · 5 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 25105.Sep 8 2014, 3:57 AM

joshuaspence retitled this revision from to Add an XHPAST linter rule to ensure that only one statement exists per line.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 8 2014, 3:57 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2460: Diff 25105.Sep 8 2014, 3:58 AM

Hmm, I wonder if looking for n_STATEMENT or whatever might be cleaner? Not sure if that would get you everything you want, though.

Perhaps... let me give that a try

Use n_STATEMENT_LIST instead of the ; token. Provide replacement text

Harbormaster completed remote builds in B2471: Diff 25130.Sep 9 2014, 12:45 PM

Rebase

Harbormaster completed remote builds in B2638: Diff 25367.Sep 25 2014, 1:15 PM

Rebase. Still not quite working

Rebase, still not quite ready

I'm going to merge this into D11504.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

31 lines

__tests__/

xhpast/

one-statement-per-line.lint-test

20 lines

switches.lint-test

4 lines

Diff 26636

src/lint/linter/ArcanistXHPASTLinter.php

Loading...

src/lint/linter/tests/xhpast/one-statement-per-line.lint-test

Loading...

src/lint/linter/tests/xhpast/switches.lint-test

Loading...