Page MenuHomePhabricator

Build separate comments for each inline comment in Audit
ClosedPublic

Authored by epriestley on Jul 22 2014, 9:54 PM.
Tags
None
Referenced Files
F13139695: D10023.diff
Fri, May 3, 3:10 AM
Unknown Object (File)
Mon, Apr 29, 2:39 PM
Unknown Object (File)
Sat, Apr 27, 2:02 PM
Unknown Object (File)
Wed, Apr 24, 10:42 PM
Unknown Object (File)
Fri, Apr 19, 2:04 AM
Unknown Object (File)
Fri, Apr 19, 2:04 AM
Unknown Object (File)
Fri, Apr 19, 2:04 AM
Unknown Object (File)
Fri, Apr 19, 2:04 AM
Subscribers

Details

Summary

Ref T4896. Moves us closer to migrating comments to transactions by building a transaction per inline.

This makes the UI a little wonky, and it will get slightly worse until we swap to the new UI and grouping/collapsing starts working. It's still usable, there's just a box per inline.

Test Plan
  • Added a comment.
  • Added an inline comment.
  • Added a comment and an inline comment.

Diff Detail

Repository
rP Phabricator
Branch
audit7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1848
Build 1849: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Build separate comments for each inline comment in Audit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
  • Skip inlines when building the mail, they get built separately.
This revision is now accepted and ready to land.Jul 23 2014, 1:59 PM
epriestley updated this revision to Diff 24202.

Closed by commit rPbf397480114d (authored by @epriestley).