Paths

Table of Contentst

Differential D10022

Allow audit email to generate from multiple transactions
ClosedPublic
Actions

Authored by epriestley on Jul 22 2014, 9:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 19, 2:04 AM

	Unknown Object (File)
	Fri, Apr 19, 2:03 AM

	Unknown Object (File)
	Fri, Apr 19, 2:03 AM

	Unknown Object (File)
	Fri, Apr 19, 2:03 AM

	Unknown Object (File)
	Mon, Apr 15, 12:07 AM

	Unknown Object (File)
	Thu, Apr 11, 3:26 AM

	Unknown Object (File)
	Tue, Apr 9, 1:46 AM

	Unknown Object (File)
	Mon, Apr 8, 10:45 PM

Subscribers

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T4896: Move Audit to ApplicationTransactions

Commits

Restricted Diffusion Commit
rP970058927987: Allow audit email to generate from multiple transactions

Summary

Ref T4896. Begins laying groundwork to split comments apart so they behave like transactions, ultimately enabling the migration.

Test Plan

Made several different types of comments, verified resulting email looks OK.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24082.Jul 22 2014, 9:30 PM

epriestley retitled this revision from to Allow audit email to generate from multiple transactions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: T4896: Move Audit to ApplicationTransactions.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 22 2014, 9:30 PM

Harbormaster completed remote builds in B1845: Diff 24082.Jul 22 2014, 9:31 PM

joshuaspence added a parent revision: D10020: Migrate Audit comment text into new storage.Jul 22 2014, 11:08 PM

joshuaspence accepted this revision.Jul 23 2014, 1:48 PM

joshuaspence edited edge metadata.

joshuaspence added inline comments.

src/applications/audit/editor/PhabricatorAuditCommentEditor.php
539	Is that any better/different to just `if ($content) {`?

This revision is now accepted and ready to land.Jul 23 2014, 1:48 PM

epriestley added inline comments.Jul 23 2014, 2:54 PM

src/applications/audit/editor/PhabricatorAuditCommentEditor.php
539	For posterity, D10020 has the reasoning -- the behavior differs on the string "0". (There's a user on GitHub with this username (https://github.com/0) and he filed an issue a while ago that his username didn't work in Phabricator. This was fixed circa rP0e672e2.)

Double-checking that lint is good.

Harbormaster completed remote builds in B1888: Diff 24148.Jul 25 2014, 12:11 AM

Closed by commit rP970058927987 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditCommentEditor.php

39 lines

Diff 24157

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...