Paths

Table of Contentst

Differential D10020

Migrate Audit comment text into new storage
ClosedPublic
Actions

Authored by epriestley on Jul 22 2014, 8:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 23, 3:59 PM

	Unknown Object (File)
	Fri, Apr 19, 2:03 AM

	Unknown Object (File)
	Fri, Apr 19, 2:03 AM

	Unknown Object (File)
	Fri, Apr 19, 2:03 AM

	Unknown Object (File)
	Fri, Apr 19, 2:03 AM

	Unknown Object (File)
	Fri, Apr 19, 2:03 AM

	Unknown Object (File)
	Mon, Apr 15, 12:31 AM

	Unknown Object (File)
	Thu, Apr 11, 3:25 AM

Subscribers

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T4896: Move Audit to ApplicationTransactions

Commits

Restricted Diffusion Commit
rP3d78c0eff707: Migrate Audit comment text into new storage

Summary

Ref T4896. This is substantially similar to D8196.

Migrate the comment text out of the audit_comment table and into the audit_transaction_comment table. Do double reads on PhabricatorAuditComment so the APIs aren't disturbed. The old table is still updated.

Test Plan

Before applying migration, cleared cache and browsed around. Things looked fine, except no comment text.
Applied migration.
Cleared cache, browsed around, saw all my old comments.
Added some new comments.
Spot checked migrated and new rows in database.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24080.Jul 22 2014, 8:22 PM

epriestley retitled this revision from to Migrate Audit comment text into new storage.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: T4896: Move Audit to ApplicationTransactions.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 22 2014, 8:22 PM

Harbormaster completed remote builds in B1843: Diff 24080.Jul 22 2014, 8:23 PM

Fix an issue when a commit has no comments.
Fix an issue when submitting a transaction with no comment text.

Harbormaster completed remote builds in B1846: Diff 24083.Jul 22 2014, 9:48 PM

joshuaspence added a parent revision: D10019: Hide Audit comment table reads behind an API.Jul 22 2014, 11:07 PM

joshuaspence accepted this revision.Jul 23 2014, 1:45 PM

joshuaspence edited edge metadata.

joshuaspence added inline comments.

resources/sql/autopatches/20140722.audit.4.migtext.php
15	Maybe just `if (!$row['content'])) {`?

This revision is now accepted and ready to land.Jul 23 2014, 1:45 PM

epriestley added inline comments.Jul 23 2014, 1:48 PM

resources/sql/autopatches/20140722.audit.4.migtext.php
15	This will incorrectly destroy the comment "0".

joshuaspence added inline comments.Jul 23 2014, 1:50 PM

resources/sql/autopatches/20140722.audit.4.migtext.php
15	Oh man... didn't realise that `(bool) "0"` was `false` in PHP.

Yeah, PHP is super cool. That's why we have all sorts of strlen(). T.T

Rebase, fix PHIDType class names.

Harbormaster completed remote builds in B1887: Diff 24147.Jul 25 2014, 12:10 AM

Closed by commit rP3d78c0eff707 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140722.audit.4.migtext.php

61 lines

src/

applications/

audit/

storage/

PhabricatorAuditComment.php

92 lines

PhabricatorAuditInlineComment.php

9 lines

Diff 24156

resources/sql/autopatches/20140722.audit.4.migtext.php

Loading...

src/applications/audit/storage/PhabricatorAuditComment.php

Loading...

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...