Page MenuHomePhabricator
Differential D10057

Use ApplicationTransactions when indexing commit/audit comments
ClosedPublic
Actions

Authored by epriestley on Jul 25 2014, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 4:01 AM
Unknown Object (File)
Mon, Apr 29, 1:11 PM
Unknown Object (File)
Mon, Apr 29, 8:06 AM
Unknown Object (File)
Fri, Apr 19, 2:04 AM
Unknown Object (File)
Fri, Apr 19, 2:04 AM
Unknown Object (File)
Fri, Apr 19, 2:04 AM
Unknown Object (File)
Mon, Apr 15, 1:27 PM
Unknown Object (File)
Thu, Apr 11, 3:27 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rPa6698f2ea53c: Use ApplicationTransactions when indexing commit/audit comments
Summary

Ref T4896. Depends on D10056. Moves search indexing to standard infrastructure.

Also, fixes a bug where inline comments would not be indexed.

Test Plan

Used bin/search index ... --trace to view index construction of a commit, saw all the comments and inlines get indexed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24182.Jul 25 2014, 11:39 PM
epriestley retitled this revision from to Use ApplicationTransactions when indexing commit/audit comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
epriestley added a parent revision: D10056: Convert Audit comment rendering to standard infrastructure.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 25 2014, 11:39 PM
Harbormaster completed remote builds in B1903: Diff 24182.Jul 25 2014, 11:41 PM
joshuaspence accepted this revision.Jul 28 2014, 12:35 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jul 28 2014, 12:35 PM
epriestley closed this revision.Jul 28 2014, 10:02 PM
epriestley updated this revision to Diff 24206.

Closed by commit rPa6698f2ea53c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
search/
25 lines
search/
index/
1 line

Diff 24206

View Options

src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php

Loading...
View Options

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

Loading...
Phabricator · Built by Phacility