Page MenuHomePhabricator
Differential D10023

Build separate comments for each inline comment in Audit
ClosedPublic
Actions

Authored by epriestley on Jul 22 2014, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 1:58 PM
Unknown Object (File)
Mon, Dec 9, 10:37 AM
Unknown Object (File)
Sun, Dec 8, 3:24 PM
Unknown Object (File)
Sat, Dec 7, 9:02 PM
Unknown Object (File)
Nov 19 2024, 5:40 AM
Unknown Object (File)
Nov 18 2024, 12:40 AM
Unknown Object (File)
Nov 15 2024, 2:53 AM
Unknown Object (File)
Nov 11 2024, 4:42 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rPbf397480114d: Build separate comments for each inline comment in Audit
Summary

Ref T4896. Moves us closer to migrating comments to transactions by building a transaction per inline.

This makes the UI a little wonky, and it will get slightly worse until we swap to the new UI and grouping/collapsing starts working. It's still usable, there's just a box per inline.

Test Plan
  • Added a comment.
  • Added an inline comment.
  • Added a comment and an inline comment.

Diff Detail

Repository
rP Phabricator
Branch
audit7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1848
Build 1849: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24084.Jul 22 2014, 9:54 PM
epriestley retitled this revision from to Build separate comments for each inline comment in Audit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 22 2014, 9:54 PM
epriestley updated this revision to Diff 24085.Jul 22 2014, 9:55 PM
  • Skip inlines when building the mail, they get built separately.
Harbormaster completed remote builds in B1847: Diff 24084.Jul 22 2014, 9:55 PM
Harbormaster completed remote builds in B1848: Diff 24085.
joshuaspence added a parent revision: D10022: Allow audit email to generate from multiple transactions.Jul 22 2014, 11:09 PM
joshuaspence accepted this revision.Jul 23 2014, 1:59 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2014, 1:59 PM
epriestley closed this revision.Jul 28 2014, 9:59 PM
epriestley updated this revision to Diff 24202.

Closed by commit rPbf397480114d (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
constants/
1 line
editor/
29 lines

Diff 24085

View Options

src/applications/audit/constants/PhabricatorAuditActionConstants.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
Phabricator · Built by Phacility