Differential D9983
Don't explicitly name abstract base classes Authored by joshuaspence on Jul 19 2014, 6:08 AM. Tags None Referenced Files
Subscribers
Details
Ref T5655. It is superfluous to include "base" in the name of an abstract base class. Furthermore, it is not done consistently within the code base. In order to retain compatibility with external code, I have kept the ArcanistBaseWorkflow class (which trivially extends from ArcanistWorkflow), but it is now deprecated and should output a warning message. Similarly for ArcanistBaseUnitTestEngine. Created a workflow which extends from ArcanistBaseWorkflow. Executed the workflow and saw a deprecation warning.
Diff Detail
Event TimelineComment Actions There are a couple of classes remaining, which I wasn't sure what to do with:
Comment Actions I think renaming ArcanistBaseWorkflow without warning will break too many installs. Can we provide a migration path instead? Specifically, add a new ArcanistBaseWorkflow class which extends ArcanistWorkflow and either overrides some method (if convenient) or gets an instanceof check during startup, causing emission of a deprecation warning?
| ||||||||||||||||||||||||||||||||||||||||||||||||