Page MenuHomePhabricator
Differential D9851

Stop reads and writes to projectPHIDs property on ManiphestTask
ClosedPublic
Actions

Authored by epriestley on Jul 6 2014, 3:28 PM.
Tags
None
Referenced Files
F13840395: D9851.id.diff
Thu, Sep 26, 12:58 PM
Unknown Object (File)
Fri, Sep 20, 7:49 AM
Unknown Object (File)
Thu, Sep 12, 3:24 PM
Unknown Object (File)
Wed, Sep 11, 6:38 PM
Unknown Object (File)
Wed, Sep 4, 5:08 PM
Unknown Object (File)
Mon, Sep 2, 5:32 AM
Unknown Object (File)
Aug 21 2024, 6:10 PM
Unknown Object (File)
Aug 21 2024, 3:22 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
chad
Maniphest Tasks
T5245: Migrate Maniphest Projects to use edge infrastructure
Commits
Restricted Diffusion Commit
rPb8b59895eeec: Stop reads and writes to projectPHIDs property on ManiphestTask
Summary

Ref T5245. This property predates edges and is unusual in modern applications. Stop writes to it and populate it implicitly from edges when querying.

Test Plan
  • Viewed task list.
  • Created a task.
  • Added and removed projects from tasks.

Diff Detail

Repository
rP Phabricator
Branch
projedge10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/query/ManiphestTaskQuery.php:339XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 1574
Build 1575: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23622.Jul 6 2014, 3:28 PM
epriestley retitled this revision from to Stop reads and writes to projectPHIDs property on ManiphestTask.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad, btrahan.
epriestley added a task: T5245: Migrate Maniphest Projects to use edge infrastructure.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 6 2014, 3:28 PM
Harbormaster completed remote builds in B1554: Diff 23622.Jul 6 2014, 3:29 PM
joshuaspence added a parent revision: D9850: Move task/project storage to edges.Jul 6 2014, 10:21 PM
epriestley updated this revision to Diff 23642.Jul 7 2014, 5:18 PM
  • Rebasing on changes further down in the stack.
Harbormaster completed remote builds in B1574: Diff 23642.Jul 7 2014, 5:19 PM
epriestley updated this revision to Diff 23644.Jul 7 2014, 5:22 PM
  • Modern edgetype classes.
Harbormaster completed remote builds in B1576: Diff 23644.Jul 7 2014, 5:23 PM
btrahan accepted this revision.Jul 10 2014, 5:07 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 10 2014, 5:07 PM
epriestley closed this revision.Jul 17 2014, 10:42 PM
epriestley updated this revision to Diff 23933.

Closed by commit rPb8b59895eeec (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
6 lines
editor/
5 lines
query/
21 lines
storage/
14 lines
7 lines

Diff 23642

View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTaskProject.php

Loading...
Phabricator · Built by Phacility