Page MenuHomePhabricator

Remove all edge events
ClosedPublic

Authored by epriestley on Jul 5 2014, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 4:05 AM
Unknown Object (File)
Sat, Nov 23, 1:30 AM
Unknown Object (File)
Sat, Nov 23, 12:36 AM
Unknown Object (File)
Thu, Nov 21, 1:22 AM
Unknown Object (File)
Tue, Nov 19, 1:27 AM
Unknown Object (File)
Mon, Nov 18, 3:09 AM
Unknown Object (File)
Mon, Nov 18, 3:09 AM
Unknown Object (File)
Mon, Nov 18, 3:09 AM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by joshuaspence.

Details

Summary

Ref T5245. These were a bad idea.

We no longer need actors for edge edits either, so remove those. Generally, edges have fit into the policy model as pure/low-level infrastructure, and they do not have any policy or capability information in and of themselves.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
projedge5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1560
Build 1560: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove all edge events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad, btrahan.

(Sorry about changing all of the dependencies around, was trying to make this diff arc patchable... but no luck)

This looks good... I just have one question.

src/infrastructure/edges/editor/PhabricatorEdgeEditor.php
24

Why does PhabricatorEdgeEditor no longer extend PhabricatorEditor?

epriestley edited edge metadata.
  • Add a note about low-levelness.

Oops -- shuffled away my inline, but the short version is that the base Editor class has setActor(), which has no effect here and is somewhat misleading (this editor applies below the policy layer).

This revision is now accepted and ready to land.Jul 7 2014, 4:21 AM
epriestley edited edge metadata.
  • Just pulling in rebase changes.
epriestley updated this revision to Diff 23928.

Closed by commit rP8cbfb49b4e93 (authored by @epriestley).