Page MenuHomePhabricator
Differential D9640

Update callsites of `phutil_json_decode`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 20 2014, 8:21 AM.
Tags
None
Referenced Files
F15389414: D9640.id23129.diff
Sat, Mar 15, 5:13 AM
F15373073: D9640.id23129.diff
Wed, Mar 12, 2:28 PM
F15345553: D9640.diff
Mon, Mar 10, 11:23 AM
F15333643: D9640.id23136.diff
Sat, Mar 8, 3:41 AM
Unknown Object (File)
Mon, Mar 3, 6:56 PM
Unknown Object (File)
Feb 18 2025, 10:01 PM
Unknown Object (File)
Feb 9 2025, 1:45 PM
Unknown Object (File)
Feb 9 2025, 1:45 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPa4a8cfa6d632: Update callsites of `phutil_json_decode`.
Summary

Depends on D9634. phutil_json_decode now throws an exception on invalid JSON.

Test Plan

arc unit

Diff Detail

Repository
rP Phabricator
Branch
jsonupdate
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1263
Build 1263: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23129.Jun 20 2014, 8:21 AM
joshuaspence retitled this revision from to Update callsites of `phutil_json_decode`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D9634: Modify `phutil_json_decode` to use `PhutilJSONParser`..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 8:21 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1263: Diff 23129.Jun 20 2014, 8:22 AM
epriestley accepted this revision.Jun 20 2014, 12:37 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2014, 12:37 PM
joshuaspence closed this revision.Jun 20 2014, 2:39 PM
joshuaspence updated this revision to Diff 23136.

Closed by commit rPa4a8cfa6d632 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
applications/
config/
custom/
17 lines
dashboard/
paneltype/
5 lines
differential/
customfield/
6 lines
6 lines
parser/
__tests__/
13 lines

Diff 23129

View Options

src/applications/config/custom/PhabricatorConfigJSONOptionType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php

Loading...
View Options

src/applications/differential/customfield/DifferentialAuditorsField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialJIRAIssuesField.php

Loading...
View Options

src/applications/differential/parser/__tests__/DifferentialCommitMessageParserTestCase.php

Loading...
Phabricator · Built by Phacility