Paths

Table of Contentst

Differential D9627

Add an optional mode for `PhutilJSONParser` to detect duplicate keys
ClosedPublic
Actions

Authored by joshuaspence on Jun 19 2014, 1:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 2:08 AM

	Unknown Object (File)
	Fri, Nov 22, 12:57 AM

	Unknown Object (File)
	Thu, Nov 21, 9:39 PM

	Unknown Object (File)
	Mon, Nov 18, 11:29 AM

	Unknown Object (File)
	Mon, Nov 18, 11:29 AM

	Unknown Object (File)
	Mon, Nov 18, 11:29 AM

	Unknown Object (File)
	Mon, Nov 18, 11:29 AM

	Unknown Object (File)
	Mon, Nov 18, 11:16 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5297: Create a native JSON parser.

Commits

rPHU384bdaa1cc70: Add an optional mode for `PhutilJSONParser` to detect duplicate keys

Summary

Ref T5297. Change PhutilJSONParser to disallow duplicate keys by default. In addition, add an optional mode to allow duplicate keys. One important caveat here is that PhutilJSONParser will return the first value in the case of a duplicate, whereas json_decode will return the last value.

Depends on D9624.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository

Branch

json4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1252
Build 1252: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23091.Jun 19 2014, 1:58 AM

joshuaspence retitled this revision from to Add an optional mode for `PhutilJSONParser` to detect duplicate keys.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5297: Create a native JSON parser..

joshuaspence added a parent revision: D9624: Throw better exceptions from `PhutilJSONParser`..

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 19 2014, 1:58 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1238: Diff 23091.Jun 19 2014, 1:59 AM

epriestley accepted this revision.Jun 19 2014, 6:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 19 2014, 6:01 PM

Minor fixes.

I've changed this a bit since it was initially accepted.

Harbormaster completed remote builds in B1252: Diff 23113.Jun 20 2014, 12:36 AM

epriestley accepted this revision.Jun 20 2014, 1:38 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/parser/PhutilJSONParser.php
14–15	For consistency, `return $this;`.

This revision is now accepted and ready to land.Jun 20 2014, 1:38 AM

Closed by commit rPHU384bdaa1cc70 (authored by @joshuaspence).

epriestley mentioned this in D21865: Updates for PHP 8.2 compatibility - Arcanist.May 27 2023, 4:03 AM

Revision Contents
Changeset List

Path

Size

externals/

jsonlint/

src/

Seld/

JsonLint/

6 lines

src/

parser/

PhutilJSONParser.php

28 lines

__tests__/

PhutilJSONParserTestCase.php

25 lines

Diff 23113

externals/jsonlint/src/Seld/JsonLint/JsonParser.php

Loading...

src/parser/PhutilJSONParser.php

Loading...

src/parser/tests/PhutilJSONParserTestCase.php

Loading...