Page MenuHomePhabricator

Status Closed should also concieved as Accepted
AbandonedPublic

Authored by dragoon20 on Jun 27 2016, 8:48 AM.
Tags
None
Referenced Files
F14038403: D16180.diff
Sun, Nov 10, 11:24 PM
F14031831: D16180.diff
Sat, Nov 9, 12:02 PM
F14024123: D16180.diff
Thu, Nov 7, 6:12 AM
F14014120: D16180.id38926.diff
Sat, Nov 2, 10:33 PM
F13997689: D16180.diff
Thu, Oct 24, 5:41 AM
F13981370: D16180.id38926.diff
Sat, Oct 19, 4:07 PM
F13979727: D16180.id.diff
Sat, Oct 19, 6:06 AM
F13968168: D16180.id38926.diff
Wed, Oct 16, 7:02 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This is related to a scenarion in https://secure.phabricator.com/T4754.

  • arc feature
  • ... do work ...
  • arc diff
  • (Diff accepted)
  • arc land
  • (Herald rule checks status == accepted, allows commit)
  • (Commit worker detects diff and closes it)
  • git checkout lts
  • git cherry-pick master
  • git push ....
  • (Herald rule sees status == closed, rejects push) *(this should be allowed)*
Test Plan

Herald rule for differential accepted should return true when diff is closed

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12805
Build 16309: arc lint + arc unit

Event Timeline

dragoon20 retitled this revision from to Status Closed should also concieved as Accepted.
dragoon20 updated this object.
dragoon20 edited the test plan for this revision. (Show Details)
dragoon20 added a reviewer: epriestley.
epriestley edited edge metadata.

See T9838 / D15085.

This revision now requires changes to proceed.Jun 27 2016, 12:00 PM

I see, thanks for the comment.
Hope it will land soon.