HomePhabricator

Revision substate CLOSED_FROM_ACCEPTED

Description

Revision substate CLOSED_FROM_ACCEPTED

Summary:
Ref T9838.

Add a Properties field to Revision, and update a wasAcceptedBeforeClose when closing a revision.

Test Plan:
A quick run through the obvious steps (Close with commit/manually, with or w/o accept) and calling differential.query shows the wasAcceptedBeforeClose property was setup correctly.

Pushing closed + accepted passes the relevant herald, which was my immediate issue; Pushing un-accepted is blocked.
Test the "commit" rule (Different from "pre-commit") by hacking the DB and running the "has accepted revision" rule in a test-console.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T9838

Differential Revision: https://secure.phabricator.com/D15085

Details

Provenance
aviveyAuthored on Jun 27 2016, 8:29 PM
industryPushed on Jun 27 2016, 8:29 PM
Reviewer
Blessed Reviewers
Differential Revision
D15085: Revision substate CLOSED_FROM_ACCEPTED
Parents
rPe984f0eb76fe: Update quickstart.sql
Branches
Unknown
Tags
Unknown
Tasks
T9838: Add sub-state for Revision: "Closed from Accepted"
Build Status
Buildable 12808
Build 16313: Run Core Tests