Diffusion Phabricator 1d1a60fdda88

Improve rendering of Herald rules in "Another Herald rule..." field
1d1a60fdda88
Actions

Description

Improve rendering of Herald rules in "Another Herald rule..." field

Summary:
Fixes T9136.

Fix a bug where the name is rendered improperly.
Put disabled rules at the bottom.
Always show the rule monogram so you can distingiush between rules with the same name.

Test Plan:

Screen Shot 2019-09-09 at 1.24.21 PM.png (274×704 px, 50 KB)

Maniphest Tasks: T9136

Differential Revision: https://secure.phabricator.com/D20798

Details

Provenance

epriestley	Authored on Sep 9 2019, 8:24 PM
epriestley	Pushed on Sep 9 2019, 8:29 PM

Differential Revision

D20798: Improve rendering of Herald rules in "Another Herald rule..." field

Parents

rP7593a265d593: When Herald changes object subscribers, always hide the feed story

Branches

Unknown

Tags

Unknown

Tasks

T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule'

Build Status

Buildable 23417
Build 32170: Run Core Tests

Event Timeline

epriestley committed rP1d1a60fdda88: Improve rendering of Herald rules in "Another Herald rule..." field (authored by epriestley).Sep 9 2019, 8:29 PM

epriestley added a task: T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule'.

epriestley added an edge: D20798: Improve rendering of Herald rules in "Another Herald rule..." field.

Harbormaster completed building B23417: rP1d1a60fdda88: Improve rendering of Herald rules in "Another Herald rule..." field.Sep 9 2019, 8:31 PM

Changes (2)

Path

Size

src/

applications/

herald/

controller/

HeraldRuleController.php

storage/

HeraldRule.php

rP1d1a60fdda88

View Options

src/applications/herald/controller/HeraldRuleController.php