Page MenuHomePhabricator

Improve rendering of Herald rules in "Another Herald rule..." field
ClosedPublic

Authored by epriestley on Mon, Sep 9, 8:25 PM.

Details

Summary

Fixes T9136.

  • Fix a bug where the name is rendered improperly.
  • Put disabled rules at the bottom.
  • Always show the rule monogram so you can distingiush between rules with the same name.
Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, Sep 9, 8:25 PM
epriestley requested review of this revision.Mon, Sep 9, 8:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 9, 8:29 PM
This revision was automatically updated to reflect the committed changes.