Differential D20798

Improve rendering of Herald rules in "Another Herald rule..." field
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 8:25 PM.

Tags

None

Referenced Files

	F18785594: D20798.diff
	Tue, Oct 14, 6:46 AM

	F18779944: D20798.id.diff
	Sat, Oct 11, 3:56 PM

	F18734030: D20798.id.diff
	Tue, Sep 30, 10:47 PM

	F18650538: D20798.diff
	Sun, Sep 21, 12:58 AM

	F18570621: D20798.id49592.diff
	Sep 10 2025, 3:59 AM

	F18570620: D20798.id49591.diff
	Sep 10 2025, 3:59 AM

	F18567378: D20798.id.diff
	Sep 9 2025, 3:43 PM

	F18563192: D20798.diff
	Sep 9 2025, 6:27 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule'
Commits: rP1d1a60fdda88: Improve rendering of Herald rules in "Another Herald rule..." field

Summary

Fixes T9136.

Fix a bug where the name is rendered improperly.
Put disabled rules at the bottom.
Always show the rule monogram so you can distingiush between rules with the same name.

Test Plan

Screen Shot 2019-09-09 at 1.24.21 PM.png (274×704 px, 50 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 9 2019, 8:25 PM

Harbormaster completed remote builds in B23416: Diff 49591.Sep 9 2019, 8:27 PM

epriestley requested review of this revision.Sep 9 2019, 8:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:29 PM

Closed by commit rP1d1a60fdda88: Improve rendering of Herald rules in "Another Herald rule..." field (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP1d1a60fdda88: Improve rendering of Herald rules in "Another Herald rule..." field.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldRuleController.php

13 lines

storage/

HeraldRule.php

16 lines

Diff 49592

View Options

src/applications/herald/controller/HeraldRuleController.php