Page MenuHomePhabricator

Add more icon choices to Badges
ClosedPublic

Authored by chad on Mar 3 2017, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 10:09 AM
Unknown Object (File)
Feb 10 2024, 6:43 AM
Unknown Object (File)
Feb 3 2024, 2:58 PM
Unknown Object (File)
Feb 3 2024, 2:58 PM
Unknown Object (File)
Feb 3 2024, 2:58 PM
Unknown Object (File)
Jan 25 2024, 4:20 AM
Unknown Object (File)
Jan 22 2024, 7:22 AM
Unknown Object (File)
Nov 30 2023, 1:02 AM
Subscribers

Details

Summary

Ref T9010. This adds more icons and lets the IconChooser handle more icons more easier.

Test Plan

Test Project Icons, Badges Icons

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Actual task ref is T9010?

src/applications/files/controller/PhabricatorFileIconSetSelectController.php
34

This should work correctly for all cases we have now, but I think it does some slightly odd stuff for numbers like 24, which I believe it will lay out as:

XXXXX
XXXXX
XXXXX
XXXXX
XXXX

If we eventually let users customize this or hit weird cases, we could start with this breakpoint and then search nearby values for one that divides the count evenly, so this would end up as 4x6.

This revision is now accepted and ready to land.Mar 3 2017, 9:37 PM

I have some plans to allow any IconSet to be extended, so I'll get the edge cases then.

Specifically, it still centers the icons, so off-number should still render OK

This revision was automatically updated to reflect the committed changes.