Page MenuHomePhabricator

Add more icon choices to Badges
ClosedPublic

Authored by chad on Mar 3 2017, 9:31 PM.

Details

Summary

Ref T9010. This adds more icons and lets the IconChooser handle more icons more easier.

Test Plan

Test Project Icons, Badges Icons

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad created this revision.Mar 3 2017, 9:31 PM
epriestley accepted this revision.Mar 3 2017, 9:37 PM

Actual task ref is T9010?

src/applications/files/controller/PhabricatorFileIconSetSelectController.php
34

This should work correctly for all cases we have now, but I think it does some slightly odd stuff for numbers like 24, which I believe it will lay out as:

XXXXX
XXXXX
XXXXX
XXXXX
XXXX

If we eventually let users customize this or hit weird cases, we could start with this breakpoint and then search nearby values for one that divides the count evenly, so this would end up as 4x6.

This revision is now accepted and ready to land.Mar 3 2017, 9:37 PM
chad added a comment.EditedMar 3 2017, 9:43 PM

I have some plans to allow any IconSet to be extended, so I'll get the edge cases then.

chad edited the summary of this revision. (Show Details)Mar 3 2017, 9:45 PM

Specifically, it still centers the icons, so off-number should still render OK

This revision was automatically updated to reflect the committed changes.