Ref T9010. This adds more icons and lets the IconChooser handle more icons more easier.
Details
Details
Test Project Icons, Badges Icons
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Actual task ref is T9010?
| src/applications/files/controller/PhabricatorFileIconSetSelectController.php | ||
|---|---|---|
| 34 | This should work correctly for all cases we have now, but I think it does some slightly odd stuff for numbers like 24, which I believe it will lay out as: XXXXX XXXXX XXXXX XXXXX XXXX If we eventually let users customize this or hit weird cases, we could start with this breakpoint and then search nearby values for one that divides the count evenly, so this would end up as 4x6. | |
Comment Actions
I have some plans to allow any IconSet to be extended, so I'll get the edge cases then.