Paths

Table of Contentst

Cache application visibility in the request cache
ClosedPublic
Actions

Authored by epriestley on Jun 17 2015, 1:11 AM.

Details

Reviewers

btrahan
avivey

Maniphest Tasks

T8575: Reap easy performance improvements

Commits

Restricted Diffusion Commit
rP8484adcffdf6: Cache application visibility in the request cache

Summary

Ref T8575. We check if users can see applications frequently, and caching on the Query isn't especially effective. Use the new Request cache instead.

Test Plan

Saw /feed/ drop 7% (from ~830ms to ~770ms) on profiles.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32237.Jun 17 2015, 1:11 AM

epriestley retitled this revision from to Cache application visibility in the request cache.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8575: Reap easy performance improvements.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 17 2015, 1:11 AM

+1lgtm

This revision is now accepted and ready to land.Jun 17 2015, 2:17 AM

Closed by commit rP8484adcffdf6: Cache application visibility in the request cache (authored by epriestley, committed by epriestley). · Explain WhyJun 17 2015, 2:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

PhabricatorApplication.php

23 lines

infrastructure/

query/

policy/

PhabricatorPolicyAwareQuery.php

19 lines

Diff 32240

View Options

src/applications/base/PhabricatorApplication.php