Don't spend ridiculous amounts of time rebuilding orderable columns
ClosedPublic
Actions

Authored by epriestley on Jun 17 2015, 2:03 AM.

Details

Reviewers

btrahan
avivey

Maniphest Tasks

T8575: Reap easy performance improvements

Commits

Restricted Diffusion Commit
rP6933ee5fb86d: Don't spend ridiculous amounts of time rebuilding orderable columns

Summary

Ref T8575. Because orderable columns need to build custom fields, they are relatively expensive to build. Use the request cache.

(The request cache is technically more correct than static, because configuration may change between requests and we may eventually reuse interpreters.)

Test Plan

Saw home page time drop 39% (from 462ms to 283ms).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32238.Jun 17 2015, 2:03 AM

epriestley retitled this revision from to Don't spend ridiculous amounts of time rebuilding orderable columns.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8575: Reap easy performance improvements.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 17 2015, 2:03 AM

sweet.

This revision is now accepted and ready to land.Jun 17 2015, 2:13 AM

Closed by commit rP6933ee5fb86d: Don't spend ridiculous amounts of time rebuilding orderable columns (authored by epriestley, committed by epriestley). · Explain WhyJun 17 2015, 2:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

11 lines

Diff 32241

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Don't spend ridiculous amounts of time rebuilding orderable columnsClosedPublicActions