Page MenuHomePhabricator

Add repository parameter to `diffusion.findsymbols` method
ClosedPublic

Authored by joshuaspence on May 3 2015, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 5:57 PM
Unknown Object (File)
Feb 3 2024, 8:29 AM
Unknown Object (File)
Jan 27 2024, 6:51 AM
Unknown Object (File)
Jan 9 2024, 3:23 PM
Unknown Object (File)
Jan 5 2024, 3:45 PM
Unknown Object (File)
Dec 30 2023, 3:53 AM
Unknown Object (File)
Dec 24 2023, 11:57 PM
Unknown Object (File)
Dec 24 2023, 2:38 AM

Details

Summary

Ref T7977. Add a repository parameter to the diffusion.findsymbols Conduit method to allow restricting search results to the specified repository.

Test Plan

Queried the Conduit endpoint.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add repository parameter to `diffusion.findsymbols` method.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

lgtm.

src/applications/diffusion/conduit/DiffusionFindSymbolsConduitAPIMethod.php
73

maybe PHID? or both? Do we have a convention?

epriestley edited edge metadata.

Yeah, I think preferable/standard is to call the parameter repositoryPHID and return repositoryPHID with the PHID. Rest of it looks good.

This revision is now accepted and ready to land.May 3 2015, 1:10 PM
eadler added a reviewer: eadler.
This revision was automatically updated to reflect the committed changes.