Page MenuHomePhabricator

Calendar event monograms, part 4. Typing E{id} makes the object available in global search.
ClosedPublic

Authored by lpriestley on Apr 27 2015, 10:19 PM.

Details

Summary

Closes T7928, E{id} is available via global search.

Test Plan

Create calendar event, search for its monogram in global search, event should be accessible.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to T7928, Typing E{id} makes the object available in global search..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley retitled this revision from T7928, Typing E{id} makes the object available in global search. to Calendar event monograms, part 4. Typing E{id} makes the object available in global search..Apr 27 2015, 10:20 PM
lpriestley edited edge metadata.
epriestley edited edge metadata.

One minor thing.

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php
42

I think that has an extra \d* in it, it should just be like this I think:

- '/^E\d*[1-9]\d*$/i'
+ '/^E[1-9]\d*$/i'

If that was a copy/paste, the source is probably messed up too.

This revision now requires changes to proceed.Apr 27 2015, 10:23 PM
lpriestley edited edge metadata.

Removing extra d from regex.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 27 2015, 10:29 PM
This revision was automatically updated to reflect the committed changes.