HomePhabricator

Remove indirect loads of Differential revisions from Releeph requests

Description

Remove indirect loads of Differential revisions from Releeph requests

Summary:
Ref T3551. Currently, there are many layers of indirection between pull requests and revisions. After D8822, revisions and other types of requested objects are recorded directly on the request. This allows us to simplify data access and querying.

A lot of stuff here is doing instanceof checks to keep APIs stable, but most of those can go away in the long run.

Test Plan:

  • Browsed requests.
  • Verified revision-dependent fields (like "Revision", "Size", "Churn") still render correctly.
  • Called releeph.queryrequests.
  • Called releephwork.nextrequest.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T3551

Differential Revision: https://secure.phabricator.com/D8824

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Apr 20 2014, 6:55 PM
Reviewer
btrahan
Differential Revision
D8824: Remove indirect loads of Differential revisions from Releeph requests
Parents
rP65913162e760: Allow discovered but unparsed commits to be requested in Releeph
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task