Page MenuHomePhabricator
Differential D8823

Allow discovered but unparsed commits to be requested in Releeph
ClosedPublic
Actions

Authored by epriestley on Apr 20 2014, 4:11 PM.
Tags
None
Referenced Files
F14370155: D8823.id20932.diff
Fri, Dec 20, 5:37 PM
Unknown Object (File)
Wed, Nov 27, 3:54 AM
Unknown Object (File)
Sat, Nov 23, 11:43 AM
Unknown Object (File)
Nov 18 2024, 9:28 PM
Unknown Object (File)
Nov 15 2024, 3:11 PM
Unknown Object (File)
Nov 11 2024, 6:11 PM
Unknown Object (File)
Nov 11 2024, 7:55 AM
Unknown Object (File)
Nov 7 2024, 7:29 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP65913162e760: Allow discovered but unparsed commits to be requested in Releeph
Summary

Ref T3662. Releeph blocks users from requsting unparsed commits, but there's no real technical reason for this.

The releephwork.getorigcommitmessage method assumes data exists, but should be replaced with diffusion.querycommits anyway.

Test Plan

Ran diffusion.querycommits. Requested a commit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20932.Apr 20 2014, 4:11 PM
epriestley retitled this revision from to Allow discovered but unparsed commits to be requested in Releeph.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 20 2014, 4:11 PM
Harbormaster completed remote builds in B20: Diff 20932.Apr 20 2014, 4:12 PM
btrahan accepted this revision.Apr 20 2014, 4:58 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/diffusion/conduit/ConduitAPI_diffusion_querycommits_Method.php
77

i'm surprised there's no commitToDict() function somewhere.

This revision is now accepted and ready to land.Apr 20 2014, 4:58 PM
epriestley closed this revision.Apr 20 2014, 6:55 PM
epriestley updated this revision to Diff 20941.

Closed by commit rP65913162e760 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
conduit/
21 lines
releeph/
conduit/
work/
controller/
request/
9 lines

Diff 20941

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_querycommits_Method.php

Loading...
View Options

src/applications/releeph/conduit/work/ConduitAPI_releephwork_getorigcommitmessage_Method.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestEditController.php

Loading...
Phabricator · Built by Phacility