Page MenuHomePhabricator

Remove ReleephUserView
ClosedPublic

Authored by epriestley on Mar 28 2014, 3:06 AM.
Tags
None
Referenced Files
F15482266: D8631.id20493.diff
Wed, Apr 9, 3:59 AM
F15480513: D8631.diff
Tue, Apr 8, 2:37 PM
F15472142: D8631.id20472.diff
Sat, Apr 5, 11:04 AM
F15460043: D8631.id20472.diff
Mon, Mar 31, 7:35 PM
F15459563: D8631.id.diff
Mon, Mar 31, 2:07 PM
F15456882: D8631.id20493.diff
Sun, Mar 30, 12:49 PM
F15450464: D8631.id.diff
Fri, Mar 28, 3:50 PM
F15443291: D8631.diff
Thu, Mar 27, 3:32 AM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP6c8cef3bee35: Remove ReleephUserView
Summary

Fixes T3738. Facebook uses this to provide a couple of integrations (push karma, is user an intern?), but the mechanism is both very complex and not very general.

Instead, these features are better implemented in Hovercards or via CustomField. We'll help Facebook integrate things when the time comes, but per discussion in T3738 none of this is critical or especially complicated.

Test Plan
  • Grepped for all callsites.
  • Viewed a request and verified that author/requestor populated and rendered correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove ReleephUserView.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: Restricted Maniphest Task.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2014, 3:35 PM
epriestley updated this revision to Diff 20493.

Closed by commit rP6c8cef3bee35 (authored by @epriestley).