When replying in a differential revision or maniphest task, it might be nice to have a quote button next to each update to automatically copy & quote the text of that update into the comment box. This is fairly widely implemented on redmine & Atlassian products, as well as Bugzilla.
Description
Description
Revisions and Commits
Revisions and Commits
| rPHU libphutil | |||
| D8954 | rPHU1e703ff15309 Make blockquotes use parent/child rules | ||
| D8953 | rPHUb88b8ba78580 Introduce a quoted reply block rule for Remarkup | ||
| rP Phabricator | |||
| D8983 | rP85bc05be255e Make two small fixes to the quoting feature | ||
| D8957 | rP707c5aec8138 Add a quote action to Differential and Maniphest | ||
| D8955 | rPb3476af5f038 Add support and very basic styling for quotes in Phabricator | ||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | epriestley | T4119 Button to automatically copy & quote text | ||
| Resolved | chad | T4962 Maybe improve styles for nested blockquotes and quoted text |
Event Timeline
Comment Actions
I think this is desirable, but we should probably include enough metadata in the quote syntax to refer to the original post.
Comment Actions
This could also be a link or something -- it's probably mostly blocked on the technical side since I'm hesitant to put some easy-but-ugly piece of syntax in the body, like:
{quote, src=PHID-TXCM-asd8yf98adsf98f9g}It would probably be better if the syntax looked more like:
>>> In comment #3, @chad wrote: > blah blah blah blah quoted text blah blah > blah blah blah blah blah blah blah blah
...but this is slightly harder to implement if the rendering needs to know anything about the original comment, because comments are currently rendered independently. We can sort of fake this and just trust the text, but then users could do silly stuff like:
>>> In comment #666, @chad wrote: > i am dum lol and i hate doges
That's probably fine, but it would be vaguely nice if this syntax required that the source comment and author attribution actually exist, at a minimum. Without lookups like this, we also can't do stuff like showing replies in the UI (e.g., "6 people replied to this").
None of this is intractable, but all of it tends to tread new ground on the infrastructure side of things.
Comment Actions
@chad being "dum and hating doges" isn't so bad, it is easily falsifiable.
If y'all are going the direction of having "6 people replied to this", then you might as well just have threaded comments too.
Comment Actions
but doges are nice :(
I'm going to close this and subtask you to maybe look at the CSS eventually since I think the styles of the "In X, Y wrote..." could probably use a bit of refinement, but it seems to work OK now.
Comment Actions
How long do you think it will be before we get a feature request to automatically fold/collapse quoted text?
Comment Actions
How long do you think it will be before we get a feature request to automatically fold/collapse quoted text?
Comment Actions
Extra "`" appeared in https://secure.phabricator.com/T3820#32 after quoting a comment containing three grave accents.