Make two small fixes to the quoting feature
ClosedPublic
Actions

Authored by epriestley on May 5 2014, 6:21 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4119: Button to automatically copy & quote text

Commits

Restricted Diffusion Commit
rP85bc05be255e: Make two small fixes to the quoting feature

Summary

Ref T4119.

Trim newlines off the quoted text before quoting it; otherwise we can end up with a staircase of ">" at the end of a quote.
Allow image macros to have leading whitespace, so multiple consecuitive quoted macros work properly.

Test Plan

I QUOTED MACROS A LOT OF TIMES

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21324.May 5 2014, 6:21 PM

epriestley retitled this revision from to Make two small fixes to the quoting feature.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T4119: Button to automatically copy & quote text.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 5 2014, 6:21 PM

chad accepted this revision.May 5 2014, 6:22 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 5 2014, 6:22 PM

Harbormaster completed remote builds in B251: Diff 21324.May 5 2014, 6:23 PM

Closed by commit rP85bc05be255e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

remarkup/

PhabricatorRemarkupRuleImageMacro.php

2 lines

transactions/

controller/

PhabricatorApplicationTransactionCommentQuoteController.php

1 line

Diff 21325

View Options

src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php