Page MenuHomePhabricator

Make blockquotes use parent/child rules

Authored by epriestley on May 2 2014, 5:26 PM.
Referenced Files
Unknown Object (File)
Sat, Mar 11, 5:07 PM
Unknown Object (File)
Wed, Mar 1, 9:20 AM
Unknown Object (File)
Feb 17 2023, 4:10 PM
Unknown Object (File)
Feb 16 2023, 5:12 PM
Unknown Object (File)
Feb 16 2023, 4:17 PM
Unknown Object (File)
Feb 6 2023, 11:17 AM
Unknown Object (File)
Feb 3 2023, 6:41 PM
Unknown Object (File)
Jan 25 2023, 8:44 PM



Ref T4119. This makes blockquotes generally work better (lists, code blocks, and other block elements will continue to work inside them). Particularly, it makes inline replies inside of quoted blocks tend to work better.

This changes some edge cases of the semantics slightly, but overall the results should be more reasonable and consistent.

Test Plan

Screen_Shot_2014-05-02_at_10.24.27_AM.png (649×557 px, 30 KB)

Diff Detail

rPHU libphutil
Lint Skipped
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make blockquotes use parent/child rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
  • Slightly simpler ruleset.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 7:08 PM
epriestley updated this revision to Diff 21310.

Closed by commit rPHU1e703ff15309 (authored by @epriestley).