Page MenuHomePhabricator

Make blockquotes use parent/child rules
ClosedPublic

Authored by epriestley on May 2 2014, 5:26 PM.
Tags
None
Referenced Files
F14007582: D8954.id21245.diff
Tue, Oct 29, 8:24 AM
F14006776: D8954.id.diff
Mon, Oct 28, 5:08 PM
F14005542: D8954.id21310.diff
Sun, Oct 27, 3:12 PM
F13995144: D8954.diff
Wed, Oct 23, 10:54 AM
F13981332: D8954.id21310.diff
Sat, Oct 19, 3:51 PM
F13969092: D8954.id21246.diff
Thu, Oct 17, 12:28 AM
Unknown Object (File)
Oct 11 2024, 4:08 AM
Unknown Object (File)
Oct 9 2024, 4:01 PM
Subscribers

Details

Summary

Ref T4119. This makes blockquotes generally work better (lists, code blocks, and other block elements will continue to work inside them). Particularly, it makes inline replies inside of quoted blocks tend to work better.

This changes some edge cases of the semantics slightly, but overall the results should be more reasonable and consistent.

Test Plan

Screen_Shot_2014-05-02_at_10.24.27_AM.png (649×557 px, 30 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make blockquotes use parent/child rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
  • Slightly simpler ruleset.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 7:08 PM
epriestley updated this revision to Diff 21310.

Closed by commit rPHU1e703ff15309 (authored by @epriestley).