Page MenuHomePhabricator

Introduce a quoted reply block rule for Remarkup

Authored by epriestley on May 2 2014, 5:11 PM.
Referenced Files
Unknown Object (File)
Feb 18 2023, 1:17 AM
Unknown Object (File)
Feb 17 2023, 12:48 AM
Unknown Object (File)
Feb 15 2023, 5:35 AM
Unknown Object (File)
Feb 13 2023, 6:12 PM
Unknown Object (File)
Feb 9 2023, 8:21 PM
Unknown Object (File)
Feb 9 2023, 1:50 AM
Unknown Object (File)
Jan 29 2023, 9:56 AM
Unknown Object (File)
Jan 25 2023, 8:44 PM



Ref T4119. The tricky part here is that it's desirable to preserve other block-level formatting elements (like lists, other quotes, etc) inside the block.

To permit that, allow block-level elements to reparse their contents into more block-level elements, and essentially build a parse tree.

The new ReplyBlockRule strips off the ">>!" header and the ">" prefixes, then renders the rest normally, then slaps a blockquote around everything.

I haven't tweaked the styles too much, @chad might have thoughts on that. There should be enough tags/classes to get things rendering pretty flexibly.

I'm probably going to make the normal quote style work like this too (so block-level elements inside it are preserved). A big thing this will help with is inline replies into these blocks. This might imply keeping both quote styles relatively similar.

The selection of ">>!" is arbitrary, but I want some unique marker to indicate the meta/header text. This seemed as good as any.

Test Plan

Screen_Shot_2014-05-02_at_10.08.15_AM.png (843×628 px, 52 KB)

Diff Detail

rPHU libphutil
Lint Skipped
Tests Skipped

Event Timeline

epriestley retitled this revision from to Introduce a quoted reply block rule for Remarkup.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a subscriber: chad.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 7:08 PM
epriestley updated this revision to Diff 21309.

Closed by commit rPHUb88b8ba78580 (authored by @epriestley).