HomePhabricator

Allow Doorkeeper references to have multiple display variations (full, short…

Description

Allow Doorkeeper references to have multiple display variations (full, short, etc.)

Summary:
Ref T13102. An install has a custom rule for bridging JIRA references via Doorkeeper and would like to be able to render them as JIRA-123 instead of JIRA JIRA-123 Full JIRA title.

I think it's reasonable to imagine future support upstream for JIRA-123, {JIRA-123}, and so on, although we do not support these today. We can take a small step toward eventual support by letting the rendering pipeline understand different view modes.

This adds an optional name (the default text rendered before we do the OAuth sync) and an optional view, which can be short or full.

Test Plan:
I tested this primarily with Asana, since it's less of a pain to set up than JIRA. The logic should be similar, hopefully.

I changed DoorkeeperAsanaRemarkupRule to specify name and view, e.g 'view' => (mt_rand(0, 1) ? 'short' : 'full'). Then I made a bunch of Asana references in a comment and saw them randomly go short or long.

Maniphest Tasks: T13102

Differential Revision: https://secure.phabricator.com/D19215