Page MenuHomePhabricator

Fix the DarkConsole inline error log stack trace expansion behavior for Content-Security-Policy
ClosedPublic

Authored by epriestley on Mar 13 2018, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:49 PM
Unknown Object (File)
Sun, Nov 17, 8:22 AM
Unknown Object (File)
Sun, Nov 17, 12:20 AM
Unknown Object (File)
Thu, Nov 7, 9:39 PM
Unknown Object (File)
Oct 23 2024, 7:32 AM
Unknown Object (File)
Oct 9 2024, 9:11 AM
Unknown Object (File)
Sep 10 2024, 1:30 AM
Unknown Object (File)
Sep 6 2024, 2:49 AM
Subscribers
None

Details

Summary

See PHI451. Ref T13102. DarkConsole uses an ancient inline "onclick" handler to expand the stack traces for errors.

The new Content-Security-Policy prevents this from functioning.

Replace this with a more modern behavior-driven action instead.

Test Plan
  • Clicked some errors in DarkConsole, saw stack traces appear.
  • Grepped for onclick and jsprintf() to see if I could find any more of these, but came up empty.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 11:45 PM
This revision was automatically updated to reflect the committed changes.