Update AphlictClientServer to support ws2 or ws3
ClosedPublic
Actions

Authored by chad on Aug 11 2017, 10:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 18, 7:53 PM

	Unknown Object (File)
	Sun, Oct 27, 7:20 AM

	Unknown Object (File)
	Sun, Oct 27, 3:02 AM

	Unknown Object (File)
	Oct 19 2024, 8:25 PM

	Unknown Object (File)
	Oct 7 2024, 12:08 PM

	Unknown Object (File)
	Oct 6 2024, 3:57 AM

	Unknown Object (File)
	Oct 6 2024, 3:57 AM

	Unknown Object (File)
	Oct 6 2024, 3:57 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12755: Aphlict doesn't work with the latest version of `ws`

Commits

rP3b14c1fdd1cf: Update AphlictClientServer to support ws2 or ws3

Summary

This lets us support either ws2 or ws3. Fixes T12755

Test Plan

Update server to version 3, send message, watch debug log. Downgrade to 2.x, send messages, watch debug log. Everything seems OK

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Aug 11 2017, 10:03 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 11 2017, 10:03 PM

Harbormaster completed remote builds in B18037: Diff 44245.Aug 11 2017, 10:03 PM

Harbormaster completed remote builds in B18037: Diff 44245.

Consider leaving a comment about this pointing at T12755, it's not very obvious on its own.

This revision is now accepted and ready to land.Aug 11 2017, 10:12 PM

Closed by commit rP3b14c1fdd1cf: Update AphlictClientServer to support ws2 or ws3 (authored by chad, committed by chad). · Explain WhyAug 11 2017, 10:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

aphlict/

server/

lib/

AphlictClientServer.js

10 lines

Diff 44246

View Options

support/aphlict/server/lib/AphlictClientServer.js

Update AphlictClientServer to support ws2 or ws3ClosedPublicActions