Page MenuHomePhabricator
Differential D16418

Simplify PHUIObjectItemList a bit
ClosedPublic
Actions

Authored by chad on Aug 18 2016, 7:16 PM.
Tags
None
Referenced Files
F14809055: D16418.diff
Sun, Jan 26, 5:49 PM
Unknown Object (File)
Fri, Jan 24, 3:27 PM
Unknown Object (File)
Fri, Jan 24, 3:27 PM
Unknown Object (File)
Fri, Jan 24, 3:27 PM
Unknown Object (File)
Fri, Jan 24, 3:27 PM
Unknown Object (File)
Tue, Jan 21, 11:45 AM
Unknown Object (File)
Tue, Jan 21, 10:25 AM
Unknown Object (File)
Sat, Jan 18, 7:59 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP1cca7fbccef8: Simplify PHUIObjectItemList a bit
Summary

I don't think we use footicons, removing that CSS. States were added but only used in Auth, convert them to statusIcon instead.

Test Plan

Visit Auth, UIExamples, grep for setState

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39482.Aug 18 2016, 7:16 PM
chad retitled this revision from to Simplify PHUIObjectItemList a bit.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 18 2016, 7:16 PM
chad added a comment.Aug 18 2016, 7:19 PM

We don't show epoch clocks anymore either, do we?

epriestley accepted this revision.Aug 18 2016, 7:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 18 2016, 7:20 PM
epriestley added a comment.Aug 18 2016, 7:21 PM

Pretty sure nothing uses the clocks now, yeah.

chad updated this revision to Diff 39483.Aug 18 2016, 7:24 PM
chad edited edge metadata.
  • clean up setEpoch
chad added a comment.Aug 18 2016, 7:26 PM

64228186.jpg (365×500 px, 63 KB)

Closed by commit rP1cca7fbccef8: Simplify PHUIObjectItemList a bit (authored by chad, committed by chad). · Explain WhyAug 18 2016, 7:27 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.Aug 19 2016, 11:50 AM
epriestley mentioned this in D16420: Keep setIcon() working for now on PHUIObjectItemView.Aug 19 2016, 11:55 AM
epriestley mentioned this in rP1ecce605890c: Keep setIcon() working for now on PHUIObjectItemView.Aug 19 2016, 2:26 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
auth/
controller/
config/
6 lines
uiexample/
examples/
49 lines
view/
phui/
9 lines
88 lines
webroot/
rsrc/
css/
phui/
69 lines

Diff 39484

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

Loading...
View Options

src/applications/uiexample/examples/PHUIObjectItemListExample.php

Loading...
View Options

src/view/phui/PHUIObjectItemListView.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility