HomePhabricator

Keep setIcon() working for now on PHUIObjectItemView

Description

Keep setIcon() working for now on PHUIObjectItemView

Summary:
Ref T11501. This method was removed in D16418, but still has some callsites. I know of four:

  • Config
  • Settings
  • Drydock main page
  • Almanac main page

Since I might be missing some and it's close to the release cut, just put the method back for now until we can clean it up more properly.

Test Plan: Viewed Settings, Config, Drydock, Almanac. No more fatal on this method being missing.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11501

Differential Revision: https://secure.phabricator.com/D16420

Details

Provenance
epriestleyAuthored on Aug 19 2016, 11:52 AM
epriestleyPushed on Aug 19 2016, 2:26 PM
Reviewer
chad
Differential Revision
D16420: Keep setIcon() working for now on PHUIObjectItemView
Parents
rP1cca7fbccef8: Simplify PHUIObjectItemList a bit
Branches
Unknown
Tags
Unknown
Tasks
T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView
Build Status
Buildable 13363
Build 17147: Run Core Tests